[IMP] Subscriptions: Renew subscriptions page rework #14768
Conversation
|
|
There was a problem hiding this comment.
Since this is a longer doc, I’m splitting my review into several passes so we can cover everything thoroughly.
In this round, I left comments on overall structure, plus a few minor formatting and style notes. Quick notes:
- no need to capitalize Odoo terms like "renewal quotation" and "chatter" when we're referring to them. Unless we're specifically referring to the "Renewal Quotation" status on the sales order.
- "sales order" rather than "sale order" as a singular term
I also have a question about scope: yesterday in the office we discussed moving the detailed instructions about how contracts in exception work (and the common pitfalls) into the Scheduled Actions doc. Is that still the plan? I want to make sure I understand whether we’re handling this across two PRs, with this one focused mainly on improving this doc.
If that’s the case, I’m curious why you modified the content in the important block instead of shortening it. Are you planning to move that content over in a follow-up PR? Knowing your plan will help me review more effectively. (:
Once you’ve addressed these comments, feel free to re-tag me for another review—it’s almost there!
| Subscription renewal is the process customers follow when they willingly choose to continue a | ||
| subscription product or service. Subscribers go through the renewal process at different intervals | ||
| -- weekly, monthly, annually, etc. -- depending on the duration of the agreed-upon contract. Most | ||
| companies that offer subscriptions prefer to automate the renewal process for customers. However, | ||
| manual subscription renewals are still used in some cases. |
There was a problem hiding this comment.
muchhh better rewrite!!!!
theRealThagomizer
force-pushed
the
18.0-subscriptions-renew-subscription-revisions-thjud
branch
from
01f832d to
b6ad1e1
Compare
|
@Felicious I made the earlier edits and adjusted the way the info is presented in the doc. I can also see that I didn't format the headings properly, so I've made a note to myself to fix that ASAP. -_-; |
theRealThagomizer
force-pushed
the
18.0-subscriptions-renew-subscription-revisions-thjud
branch
from
b6ad1e1 to
cf3db81
Compare
There was a problem hiding this comment.
I'm very proud of your improvements made to this doc, @theRealThagomizer!
The flow is much clearer now ✨ You’ve defined the prerequisite conditions for a sub up front, made the renewal steps easier to follow, and added helpful clarifications about the quotation state that really improved readability. I also appreciate how you trimmed the unnecessary side-questing about other smart buttons! it keeps the doc focused and purposeful. Excellent work! 🙌
The content is awesome; I'm marking this changes requested for really minor technical RST stuff. Since you've removed the files in the RST, we also want to remove files from the renewals folder. After you remove those, can you push up your changes and tag me for another review? It'll be a super quick double-check!
(Tip: run make review and enter the image folder to check which image files in the folder was not used in the .rst file! Below is a screenshot of it yelling at me that mrr-smart-button.png isn't used)
theRealThagomizer
force-pushed
the
18.0-subscriptions-renew-subscription-revisions-thjud
branch
from
a52a87c to
7eba537
Compare
|
|
||
| .. figure:: renewals/contract-in-exception.png | ||
| :align: center | ||
| :alt: The "contract in exception" option selected with the "payment failure" tag shown. |
There was a problem hiding this comment.
no need to fix this but just a note for you to know: we're not supposed to format the alt tags, so no need to use quotations here (:
There was a problem hiding this comment.
Oh, I'd just been using that as-is from the original version of the doc. I'll remove it and make a note for future docs.
Co-authored-by: Felicia Kuan <feku@odoo.com>
theRealThagomizer
force-pushed
the
18.0-subscriptions-renew-subscription-revisions-thjud
branch
from
fc77f2b to
5be5327
Compare
|
@robodoo r+ |
closes #14768 Signed-off-by: Thomas Jude Cavazos (thjud) <thjud@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com>
Big rework of the "Renew subscriptions" page
This 18.0 PR can be FWP up to master.
Not sure if this reaches 50% revised, so I've marked it 2 points for now.